Skip to content

Create Colors-and-Backgrounds.md #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2024
Merged

Create Colors-and-Backgrounds.md #375

merged 2 commits into from
Jun 3, 2024

Conversation

AmrutaJayanti
Copy link
Contributor

@AmrutaJayanti AmrutaJayanti commented Jun 3, 2024 •
edited
Loading

Description

Added Colors-and-Backgrounds.md

Issues Related:

Closes: #317

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): Adding Solution

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:04am

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jun 3, 2024 •
edited
Loading

Here's the code health analysis summary for commits 6630119..67a7b8b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels Jun 3, 2024
ajay-dhangar
ajay-dhangar requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change code based on suggestions

docs/CSS/css-basics/Colors-and-Backgrounds.md Outdated

Hex - Codes :

![HexCode](https://tse4.mm.bing.net/th?id=OIP.9ipFzqjVN-PlJKwrpuAiuQHaFM&pid=Api&P=0&h=180)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change size of img

docs/CSS/css-basics/Colors-and-Backgrounds.md Outdated

RGB (Red-Green-Blue):

<img src="https://tse4.mm.bing.net/th?id=OIP.zBlyNAyf8fFyqp7_vdv2mgHaCx&pid=Api&P=0&h=180" alt="RGB" height="500" width="400"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove height, width or maintain size of img

docs/CSS/css-basics/Colors-and-Backgrounds.md Outdated

HSL (Hue-Saturation-Lightness):

<img src="https://giggster.com/guide/static/fed42130c194b0c240a4ec10408adf97/8282f/hsl-cover-2.png" alt="HSL" height="200" width="200"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change size of img based on content

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AmrutaJayanti
Copy link
Contributor Author

@ajay-dhangar I made the changes . Please approve

ajay-dhangar
ajay-dhangar approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ajay-dhangar ajay-dhangar merged commit def8006 into codeharborhub:main Jun 3, 2024
8 checks passed
@AmrutaJayanti AmrutaJayanti mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@AmrutaJayanti AmrutaJayanti

Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels
Projects
@CodeHarborHub
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Colors and Backgrounds under CSS
2 participants
@AmrutaJayanti @ajay-dhangar